Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard Coded Paths In Build Scripts #9

Closed
opticyclic opened this issue Jun 13, 2019 · 0 comments · Fixed by #35
Closed

Hard Coded Paths In Build Scripts #9

opticyclic opened this issue Jun 13, 2019 · 0 comments · Fixed by #35

Comments

@opticyclic
Copy link

opticyclic commented Jun 13, 2019

Windows paths are hard-coded into the build scripts.
e.g.

var plantUmlPath = @"C:\ProgramData\chocolatey\lib\plantuml\tools\plantuml.jar";
var inkScapePath = @"C:\Program Files\Inkscape\inkscape.exe";
static string rsvgConvertPath = @"C:\ProgramData\chocolatey\bin\rsvg-convert.exe";

Even if you are on Windows you might have these installed in different locations.

It would be useful if these could be overridden with command line parameters.

For Ubuntu based distros rsvg-convert is installed with

sudo apt install librsvg2-bin

and is located at:

which rsvg-convert
/usr/bin/rsvg-convert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants