Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sample link for Proxy server #18

Closed
djbrown opened this issue Mar 26, 2024 · 2 comments
Closed

Incorrect sample link for Proxy server #18

djbrown opened this issue Mar 26, 2024 · 2 comments
Labels

Comments

@djbrown
Copy link

djbrown commented Mar 26, 2024

Concerning Page

https://plantuml.com/en/server
section "Proxy service"

Problem

wrong link currently: http://www.plantuml.com/plantuml/proxy?idx=1&src=https://raw.github.com/plantuml/plantuml-server/master/src/main/webapp/resource/test2diagrams.txt

problem 1: the file was moved (see file history) to a subdirectory test.
solution: add subdirectory to url: resouce/test/test2diagrams.txt

problem 2: there is only one diagram in the file, idx starts at 0, so idx=1 fails
solution: remove idx=1& part from the url, default is 0 anyways

Solution

correct link would be: http://www.plantuml.com/plantuml/proxy?src=https://raw.github.com/plantuml/plantuml-server/master/src/main/webapp/resource/test/test2diagrams.txt

Additional context

@arnaudroques
Copy link
Contributor

Thank you for highlighting this issue and for your attempts to enhance our documentation!

We're pleased to inform you that we have updated our website based on your change. It's important to note that changes submitted through our system don't take effect immediately because we employ a review process. Since the access is free, we have to be vigilant about spam :-)

Should you come across any additional issues or have more suggestions, we encourage you to reach out or make those changes directly.

Thanks again,

Arnaud

@djbrown
Copy link
Author

djbrown commented Mar 26, 2024

Thanks :) I also fixed japanese so its fixed for all languages

@djbrown djbrown closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants