Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for #1467 #1489

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Patch for #1467 #1489

merged 3 commits into from
Jul 24, 2023

Conversation

travkin79
Copy link
Contributor

I started improving drawing qualified associations. A few issues still remain.

Otherwise, qualifier labels of qualified associations pointing left or up are drawn on the wrong end of the association.
@arnaudroques arnaudroques merged commit afada20 into plantuml:master Jul 24, 2023
9 checks passed
@arnaudroques
Copy link
Contributor

Many thanks for the fix: this part is really tricky.
Note that we have some old users that are still under Java 7(!), so we might rewrite the "stream" part so that it compiles there.
Sorry about that!

@travkin79
Copy link
Contributor Author

No problem, @arnaudroques.
I've update the code in my fork.

Is there a way to add the new commits to this PR (not creating a new PR)?

@arnaudroques
Copy link
Contributor

Is there a way to add the new commits to this PR (not creating a new PR)?

Well, I do not know :-)
Note that having a new PR is not an issue on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants