Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Activity Diagram "Stop" and "End" symbols to fill using the diagram background color instead of always using white #450

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

matthew16550
Copy link
Collaborator

Similar to #448, this PR removes Activity Diagram hard coded WHITE colors.

@startuml

skinparam ActivityEndColor red
skinparam ActivityStartColor red
skinparam BackgroundColor grey
skinparam Shadowing false

start
end
stop

@enduml

Before
activity_diagram_before

After
activity_diagram_after

…agram background color instead of always using white.
@matthew16550 matthew16550 marked this pull request as draft January 21, 2021 01:56
@matthew16550
Copy link
Collaborator Author

This might be causing an NPE, converted PR to draft while I investigate.

@matthew16550 matthew16550 marked this pull request as ready for review January 21, 2021 03:46
@matthew16550
Copy link
Collaborator Author

Never mind about the NPE, it seems that my IntelliJ PlantUML plugin was being strange 😆 .

@arnaudroques arnaudroques merged commit 55f005f into plantuml:master Jan 21, 2021
@arnaudroques
Copy link
Contributor

Thanks again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants