Specify picoweb bind address & print actual listen port #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -picoweb:8000:localhost). * Change picoweb server to print the actual port being listened on when port 0 was specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 closely related features:
Allow specifying the bind address that picoweb will listen on (e.g.
-picoweb:8000:localhost).Obviously picoweb isn't designed to be highly secure but the default is to listen on all addresses and that can be a problem in highly security conscious organisations. This PR allows specifying a single address to listen on so users can choose
localhostor some other suitable address.Existing behaviour for
-picoweb&-picoweb:PORTis not changed.When port
0is specified, the OS will assign a random available port number. This can be helpful in build pipelines where a hard coded port might be in use by another process. Picoweb already supports this but is printingwebPort=0, this PR makes it print the actual port that is being used.