-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create puml-theme-spacelab-white #757
Conversation
Hello @KingPlus-lang, Thanks to contribute to the
on the header of the theme: '' spacelab-white theme based off of the bootstrap theme of the same name
'' https://bootswatch.com/spacelab/
''
'' Adapted by [KingPlus-lang](https://github.com/KingPlus-lang)
'' from `spacelab` theme of [bschwarz](https://github.com/bschwarz)
'' Original Author: "Brett Schwarz"
'' Copyright (c) 2020 by Brett Schwarz
Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some remarks:
- Add traceability, Author, (e.g. Adapted by
X
from theme ofY
, ...) - Update theme name on the file
'' Author = "Brett Schwarz | ||
'' Copyright (c) 2020 by Brett Schwarz | ||
|
||
!$THEME = "spacelab" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps to change on spacelab-white
according to the name of the theme and to the filename of the theme.
'' superhero theme based off of the bootstrap theme of the same name | ||
'' https://bootswatch.com/spacelab/ | ||
'' | ||
'' Author = "Brett Schwarz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For traceability, could you just add:
- Adapted by KingPlus-lang from
spacelab
theme of bschwarz
Rename puml-theme-spacelab-white to puml-theme-spacelab-white.puml
📌 Sorry for all these comments (and their numbers) and the noise... 😱 See only my main comment above: #757 (comment) |
No description provided.