Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create puml-theme-spacelab-white #757

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

KingPlus-lang
Copy link
Contributor

No description provided.

@arnaudroques arnaudroques merged commit 4f6d2b0 into plantuml:master Nov 10, 2021
@The-Lum
Copy link
Collaborator

The-Lum commented Nov 14, 2021

Hello @KingPlus-lang,
FYI @bschwarz, @arnaudroques,

Thanks to contribute to the PlantUML project, here are some questions or remarks:

  1. What is the purpose of your modified theme spacelab-white?
    Is it not better an outline theme instead of a white theme...

  2. For traceability, could you just add (or other better sentences..):

on the header of the theme:

'' spacelab-white theme based off of the bootstrap theme of the same name
'' https://bootswatch.com/spacelab/
''
'' Adapted by [KingPlus-lang](https://github.com/KingPlus-lang) 
'' from `spacelab` theme of [bschwarz](https://github.com/bschwarz)
'' Original Author: "Brett Schwarz"
'' Copyright (c) 2020 by Brett Schwarz
  1. Then could you change the theme name on line 2 and 8:
    !$THEME = "spacelab"
    to
    !$THEME = "spacelab-white"
    according to the name of the theme and to the filename of the theme...

Regards,
Th.

Copy link
Collaborator

@The-Lum The-Lum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some remarks:

  • Add traceability, Author, (e.g. Adapted by X from theme of Y, ...)
  • Update theme name on the file

'' Author = "Brett Schwarz
'' Copyright (c) 2020 by Brett Schwarz

!$THEME = "spacelab"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps to change on spacelab-white according to the name of the theme and to the filename of the theme.

'' superhero theme based off of the bootstrap theme of the same name
'' https://bootswatch.com/spacelab/
''
'' Author = "Brett Schwarz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For traceability, could you just add:

@The-Lum
Copy link
Collaborator

The-Lum commented Nov 14, 2021

📌 Sorry for all these comments (and their numbers) and the noise... 😱
I discover all the functionality of Github between PR and Commits...

See only my main comment above: #757 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants