-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven build profile for building with PDF dependencies to a fat jar #781
Conversation
Yes, this is interesting! Regarding github actions, I think this should remain optional right now (that is, we won't compile with profile Thanks! |
Before we're continuing, let's first clarify one question: In the
I've dropped this temporarily in the pom. |
Sure!
Yes, you should probably restore them
I've grouped jar files per features: elk-full.jar avalon-framework-4.2.0.jar batik-all-1.7.jar commons-io-1.3.1.jar commons-logging-1.0.4.jar fop.jar xml-apis-ext-1.3.04.jar xmlgraphics-commons-1.4.jar jlatexmath-minimal-1.0.3.jar jlm_cyrillic.jar jlm_greek.jar vizjs.jar j2v8_win32_x86_64-3.1.6.jar j2v8_linux_x86_64-3.1.6.jar j2v8_macosx_x86_64-3.1.6.jar ditaa0_9.jar The idea is to put all those jar in the classpath be default so that people can optionally download required jar files and put them at the same place as Hope this helps! |
Resolve Git conflicts
Thanks for explanation! I've changed the PR to stick with the manifest.txt for the normal build. The |
I may be wrong, but I think indentation in the new pdf profile are not consistent with the rest of the file. |
You're right. I've fixed the indentation and updated the PR. |
After several attempts to collect the required jars documented here, I have a PR as a suggestion for automating an alternative build with a PDF enabled jar.
This is a change in the pom.xml to output a JAR with the PDF dependencies in case the build profile is "pdf":
I hope you find it useful.
It is possible to add this also to the github actions build.