source code java8 compatible, adjust build files to reflect this #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soloturn
changed the title
soloturn
changed the title
|
Usually, we try to support old version of Java as long as possible. I prefer to merge this merge first before dealing with #899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update: while this one adresses the java.time issue as well, kindof, please prefer merging #899 instead.
hey @arnaudroques sorry for ovlerlooking that mvn and gradle had a differing source code compatible level:
https://github.com/plantuml/plantuml/runs/5049289268?check_suite_focus=true
am not sure if java7 was deliberate choice or just historic as i could not find why. so 2 options. this pr, making mvn require java8. and other pr, lowering to java7 for gradle.