Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch default build to gradle, fixes #47 #912

Merged
merged 4 commits into from
Feb 11, 2022

Conversation

soloturn
Copy link
Contributor

in case it does not work pls revert commit 7d256ad to switch the default back to mvn.

@soloturn
Copy link
Contributor Author

the signing failed here, am not sure if it is just because its my user though. in the fork the following settings are there, and it signs the artefacts:

image

@arnaudroques
Copy link
Contributor

But why is it failing in on build(8, ubuntu-20.04) only?
And the "create artifacts" step seems to be skipped in other jobs.
Any though?

@soloturn soloturn force-pushed the master branch 3 times, most recently from 856489a to a9da3cf Compare February 11, 2022 10:54
@soloturn
Copy link
Contributor Author

soloturn commented Feb 11, 2022

But why is it failing in on build(8, ubuntu-20.04) only? And the "create artifacts" step seems to be skipped in other jobs. Any though?

found it. maven has a condition in the pom.xml to sign only when the environment variable env.SIGN_ARTIFACTS is true. on a pull request this is not true, otherwise i could create a pull request and trigger signing with your key. which makes sense. for gradle, this condition was not there. it is now in the github workflow, in 2 steps. because it does not make a lot of sense in my opinion to call "gradle sign" AND set an environment variable to make it sign.

release is not from windows 2019, daemon can be used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants