Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maven #955

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Remove maven #955

merged 2 commits into from
Mar 11, 2022

Conversation

soloturn
Copy link
Contributor

you want to remove the maven build or leave it ?

in case remove, this pull request renames the gradle workflow stuff into the original names. and removes the maven pom.

dependabot bot and others added 2 commits March 11, 2022 06:18
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.5.0 to 3.0.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v2.5.0...v3.0.0)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@arnaudroques arnaudroques merged commit eaaf59e into plantuml:master Mar 11, 2022
@arnaudroques
Copy link
Contributor

Let's try to remove maven...
However, there is an issue during the upload:

Run .github/scripts/release-gradle-snapshot.sh
  .github/scripts/release-gradle-snapshot.sh
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.2-8/x64
    GITHUB_TOKEN: ***
/home/runner/work/_temp/28d08919-8467-4a87-b84b-e2bc2397046c.sh: line 1: .github/scripts/release-gradle-snapshot.sh: No such file or directory
Error: Process completed with exit code 127.

Any idea?

@soloturn
Copy link
Contributor Author

ah, i had that one one only on master but created the PR out of the feature branch, sorry.

@matthew16550
Copy link
Collaborator

@arnaudroques I have not paid close attention recently. Do we still need pom.xml for releasing to Maven Central?

@arnaudroques
Copy link
Contributor

Do we still need pom.xml for releasing to Maven Central?

Frankly, I don't know :-)

But if we go to full gradle, and if gradle does not need pom.xml (which I suspect), then we can remove pom.xml for releasing to Maven Central.

@matthew16550
Copy link
Collaborator

Unless there is something complicated set up here, Gradle does not need pom.xml

Do we know what commands to run when we release 1.2022.3 into Maven Central?

cc @soloturn

@soloturn
Copy link
Contributor Author

how do you plubish currently? i saw there is: https://search.maven.org/artifact/net.sourceforge.plantuml/plantuml. is it:

mvn deploy
....
Uploading to sonatype-nexus-snapshots: https://oss.sonatype.org/content/repositories/snapshots/net/sourceforge/plantuml/plantuml/1.2022.1-SNAPSHOT/plantuml-1.2022.1-20220313.082801-2.jar
Uploading to sonatype-nexus-snapshots: https://oss.sonatype.org/content/repositories/snapshots/net/sourceforge/plantuml/plantuml/1.2022.1-SNAPSHOT/plantuml-1.2022.1-20220313.082801-2.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:18 min
[INFO] Finished at: 2022-03-13T09:29:19+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project plantuml: Failed to deploy artifacts: Could not transfer artifact net.sourceforge.plantuml:plantuml:jar:1.2022.1-20220313.082801-2 from/to sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots/): authentication failed for https://oss.sonatype.org/content/repositories/snapshots/net/sourceforge/plantuml/plantuml/1.2022.1-SNAPSHOT/plantuml-1.2022.1-20220313.082801-2.jar, status: 401 Unauthorized -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

?

@arnaudroques
Copy link
Contributor

We publish by running maven on a local machine.

But we would like to get rid of this, and to publish through github.
I guess we have to install some secret/token on github to allow publication with gihub action.

@soloturn soloturn mentioned this pull request Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants