Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evol/link in ref #979

Merged
merged 5 commits into from
Apr 1, 2022
Merged

Evol/link in ref #979

merged 5 commits into from
Apr 1, 2022

Conversation

gwilherm
Copy link
Contributor

@gwilherm gwilherm commented Apr 1, 2022

As @The-Lum suggested in #635 (comment)

This change puts the main link of a reference box before the : in a sequence diagram

Feel free to discuss any point

Before:

@startuml
ref over A,B : [[mainlink{tooltip}]] inline ref with [[link{tooltip} links]]

ref over A,B
  [[mainlink{tooltip}]]
  with multi line text and [[link{tooltip} links]]
endref
@enduml

After

@startuml
ref over A,B [[mainlink{tooltip}]]: [[firstlink]] inline ref with [[link{tooltip} links]]

ref over A,B [[mainlink{tooltip}]]
  [[firstlink]]
  with multi line text and [[link{tooltip} links]]
endref
@enduml

Gives:

image
Whole area link leading to "mainlink"

@arnaudroques arnaudroques merged commit c88448d into plantuml:master Apr 1, 2022
@arnaudroques
Copy link
Contributor

Many thanks for cleaning the code and the syntax.
I think that it somehow break ascending compatibility, but since the impact is very limited, I think it's still ok, since the result is more consistent.

Thanks also to @The-Lum for syntax suggestion.

@The-Lum
Copy link
Collaborator

The-Lum commented Apr 2, 2022

Hello @gwilherm, @arnaudroques, and all,

For a to-do list....

  • It is plan to do the same thing (adding topurl, ...) for group, alt, loop,...?

Sorry I am not currently a good java developer.
But I can help to populate the to-do list...

Regards.

@arnaudroques
Copy link
Contributor

  • It is plan to do the same thing (adding topurl, ...) for group, alt, loop,...?

Sorry I am not currently a good java developer. But I can help to populate the to-do list...

Well, coding is not the only way to contribute.
And your contributions in documentation, forum and to-do list are really helpful!

So populate the todo list is really a good idea. Giving short examples is also a very good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants