Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title detection: Treat non-breaking space as whitespace #41

Closed
GoogleCodeExporter opened this issue Jan 8, 2016 · 6 comments
Closed

Comments

@GoogleCodeExporter
Copy link

Character.isWhitespace(String) does not consider the non breaking space 
character (160) to be whitespace.  This causes whitespace to not be correctly 
trimmed when the non breaking space character is involved.  This can cause 
DocumentTitleMatchClassifier to miss a title match as well as other whitespace 
related problems.

The following article uses the character in the title and a few other places:
http://espn.go.com/dallas/nfl/story/_/id/7560381/do-anthony-spencer

Original issue reported on code.google.com by tucker...@gmail.com on 20 Mar 2012 at 2:58

Attachments:

@GoogleCodeExporter
Copy link
Author

Hi tuckerpmt,

thanks for reporting this. Especially the link to the article helped me 
figuring out what the problem was.
I have fixed this in r167, although in a slightly different way.

Cheers,
Christian

Original comment by ckkohl79 on 21 Mar 2012 at 9:10

  • Changed title: Title detection: Treat non-breaking space as whitespace
  • Changed state: Fixed
  • Added labels: Type-Enhancement
  • Removed labels: Type-Patch

@GoogleCodeExporter
Copy link
Author

Issue 38 has been merged into this issue.

Original comment by ckkohl79 on 21 Mar 2012 at 9:10

@GoogleCodeExporter
Copy link
Author

Issue 39 has been merged into this issue.

Original comment by ckkohl79 on 21 Mar 2012 at 9:10

@GoogleCodeExporter
Copy link
Author

Issue 42 has been merged into this issue.

Original comment by ckkohl79 on 21 Mar 2012 at 9:11

@GoogleCodeExporter
Copy link
Author

Issue 40 has been merged into this issue.

Original comment by ckkohl79 on 21 Mar 2012 at 9:11

@GoogleCodeExporter
Copy link
Author

Glad to help! :)

Though I am curious as to why you chose to scan all of the characters again 
instead of handle it where you currently are converting other whitespace 
characters to the standard space character?

Original comment by tucker...@gmail.com on 21 Mar 2012 at 10:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant