Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--fail-under flag as in coverage #24

Closed
rec opened this issue Aug 24, 2022 · 2 comments
Closed

--fail-under flag as in coverage #24

rec opened this issue Aug 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@rec
Copy link

rec commented Aug 24, 2022

Good day, and thank you for this very interesting project!

I'm going to file a few issues regarding feature parity with coverage, but feel free to do with them as you wish including nothing. :-)

Or, if you are open to pull requests, I could probably knock at least a few of them out.


The one big reason that I cannot yet adopt slipcover in my current project is that it is missing --fail-under or some facility like that which fails when the test coverage drops below a certain level.

I might well have missed this feature in your program of course.

Here's the documentation: https://coverage.readthedocs.io/en/6.4.4/cmd.html#reporting

Doesn't seem horrifyingly hard...

@jaltmayerpizzorno jaltmayerpizzorno added the enhancement New feature or request label Aug 26, 2022
@jaltmayerpizzorno
Copy link
Collaborator

Yea, this sounds trivial to implement. I'd be happy to add this in the next release, but sure, we're open to PR.

@rec
Copy link
Author

rec commented Sep 1, 2022

Ah, sorry, I simply ran out of time to do this. :-/

Hoping this all goes well for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants