Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply automated suggestions from Sourcery to plasmapy.dispersion #1562

Merged
merged 5 commits into from May 18, 2022
Merged

Apply automated suggestions from Sourcery to plasmapy.dispersion #1562

merged 5 commits into from May 18, 2022

Conversation

namurphy
Copy link
Member

This PR implements a few suggested refactorings from Sourcery to plasmapy.dispersion. The suggestions are all relatively minor.

@namurphy namurphy added refactoring ♻️ Improving an implementation without adding new functionality plasmapy.dispersion Related to the plasmapy.dispersion subpackage labels May 18, 2022
rocco8773
rocco8773 requested changes May 18, 2022
View reviewed changes
Copy link
Member

@rocco8773 rocco8773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just the bad white space in those if clauses, otherwise it looks good.

@namurphy @rocco8773
Adjust whitespace
9e4a963 
Co-authored-by: Erik Everson <eteverson@gmail.com>
@codecov
Copy link

codecov bot commented May 18, 2022 •
edited

Codecov Report

Merging #1562 (9e4a963) into main (e3e0058) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
- Coverage   97.19%   97.19%   -0.01%     
==========================================
  Files          82       82              
  Lines        7746     7745       -1     
==========================================
- Hits         7529     7528       -1     
  Misses        217      217
Impacted Files Coverage Δ
plasmapy/dispersion/analytical/two_fluid_.py 100.00% <100.00%> (ø)
plasmapy/dispersion/numerical/hollweg_.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e0058...9e4a963. Read the comment docs.

@namurphy namurphy enabled auto-merge (squash) May 18, 2022 22:01
@namurphy namurphy requested a review from rocco8773 May 18, 2022 22:01
@namurphy namurphy merged commit bcc32d0 into PlasmaPy:main May 18, 2022
rocco8773
rocco8773 approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@rocco8773 rocco8773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@namurphy namurphy deleted the sourcery-dispersion branch May 18, 2022 22:15
@namurphy namurphy mentioned this pull request May 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocco8773 rocco8773 rocco8773 approved these changes

Assignees
No one assigned
Labels
plasmapy.dispersion Related to the plasmapy.dispersion subpackage refactoring ♻️ Improving an implementation without adding new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@namurphy @rocco8773