Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to magnetostatics notebook #1588

Merged
merged 6 commits into from Jun 21, 2022

Conversation

namurphy
Copy link
Member

This PR renames magnetic_statics.ipynbmagnetostatics.ipynb, and then makes some minor updates to the text and plotting.

This PR makes some incremental progress towards #1573, but I'm not intending to fully address it in this PR since I'd like to keep the scope limited to some minor improvements prior to the 0.8.0 release.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the notebooks Related to example Jupyter notebooks in docs/examples/ label Jun 18, 2022
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #1588 (5c199ae) into main (05e5ce2) will not change coverage.
The diff coverage is n/a.

❗ Current head 5c199ae differs from pull request most recent head 9bc050b. Consider uploading reports for the commit 9bc050b to get more accurate results

@@           Coverage Diff           @@
##             main    #1588   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files          82       82           
  Lines        7895     7895           
=======================================
  Hits         7673     7673           
  Misses        222      222           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e5ce2...9bc050b. Read the comment docs.

@namurphy namurphy added the status: ready for review PRs that are ready for code review label Jun 18, 2022
@namurphy namurphy requested a review from a team June 18, 2022 01:55
@namurphy namurphy marked this pull request as ready for review June 18, 2022 01:55
@namurphy namurphy enabled auto-merge (squash) June 21, 2022 15:54
@namurphy namurphy requested a review from rocco8773 June 21, 2022 15:54
@namurphy
Copy link
Member Author

@rocco8773 — thanks for the review! I made the change you suggested, so it should be all set.

Copy link
Member

@rocco8773 rocco8773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. I can actually read the axes now! 😆

Thanks for making the update!

@namurphy namurphy merged commit c43df94 into PlasmaPy:main Jun 21, 2022
@namurphy namurphy deleted the rename-notebook branch June 21, 2022 17:53
@namurphy namurphy removed the status: ready for review PRs that are ready for code review label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebooks Related to example Jupyter notebooks in docs/examples/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants