New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace @u.quantity_input with @validate_quantities #905
Conversation
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 60 60
Lines 5414 5417 +3
=======================================
+ Hits 5209 5212 +3
Misses 205 205
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed changelog file name to reflect correct PR number
Removed blank line in imports
Removed blank line from imports
Removed blank line from imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed blank line from each added import to hopefully pass the isort test.
Edit: still not passing the isort test, any ideas for what I might be doing wrong?
isort also lets you apply its suggestions if you run it locally. We should probably state that more visibly somehow... To apply the full linter suite, use Make sure you pull the commit I added that does that for you! |
@StanczakDominik oof, I completely missed that, thank you for applying that! |
Thanks for all the help! I'm still a little rusty, so I apologize for the mess of commits in this PR :) Is there anything else I need to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
And we're not even in triple digits for the number of commits, so don't worry about it ;)
Thanks for dealing with this one!
docstrings.
Fixes #880
I changed all instances of
@u.quantity_input
with@validate_quantities
as well as imported the module forvalidate_quantities
. I am hoping this should work to fix the issue, please let me know if more work is needed. Thanks!