Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @u.quantity_input with @validate_quantities #905

Merged
merged 7 commits into from Oct 1, 2020

Conversation

cskinner74
Copy link
Contributor

@cskinner74 cskinner74 commented Oct 1, 2020

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

Fixes #880

I changed all instances of @u.quantity_input with @validate_quantities as well as imported the module for validate_quantities. I am hoping this should work to fix the issue, please let me know if more work is needed. Thanks!

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #905 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          60       60           
  Lines        5414     5417    +3     
=======================================
+ Hits         5209     5212    +3     
  Misses        205      205           
Impacted Files Coverage Δ
plasmapy/particles/ionization_state.py 92.96% <100.00%> (ø)
plasmapy/particles/ionization_states.py 90.81% <100.00%> (ø)
plasmapy/plasma/sources/plasma3d.py 100.00% <100.00%> (ø)
plasmapy/plasma/sources/plasmablob.py 100.00% <100.00%> (ø)
plasmapy/simulation/particletracker.py 98.33% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed31b1...666e036. Read the comment docs.

Copy link
Contributor Author

@cskinner74 cskinner74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed changelog file name to reflect correct PR number

Removed blank line in imports
Removed blank line from imports
Removed blank line from imports
Copy link
Contributor Author

@cskinner74 cskinner74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed blank line from each added import to hopefully pass the isort test.

Edit: still not passing the isort test, any ideas for what I might be doing wrong?

@StanczakDominik
Copy link
Member

isort also lets you apply its suggestions if you run it locally. We should probably state that more visibly somehow...

To apply the full linter suite, use pre-commit run --all :)

Make sure you pull the commit I added that does that for you!

@cskinner74
Copy link
Contributor Author

@StanczakDominik oof, I completely missed that, thank you for applying that!

@cskinner74
Copy link
Contributor Author

Thanks for all the help! I'm still a little rusty, so I apologize for the mess of commits in this PR :)

Is there anything else I need to do?

Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

And we're not even in triple digits for the number of commits, so don't worry about it ;)

Thanks for dealing with this one!

@StanczakDominik StanczakDominik merged commit 6d5651c into PlasmaPy:master Oct 1, 2020
@cskinner74 cskinner74 deleted the iss880 branch October 1, 2020 07:37
@namurphy namurphy added the plasmapy.utils Related to the plasmapy.utils subpackage label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plasmapy.utils Related to the plasmapy.utils subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all uses of quantity_input with validate_quantites
3 participants