Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate supported options and update docs #12

Merged
merged 1 commit into from Apr 2, 2019
Merged

Validate supported options and update docs #12

merged 1 commit into from Apr 2, 2019

Conversation

msaraiva
Copy link
Contributor

@msaraiva msaraiva commented Apr 2, 2019 •
edited

  • It doesn't actually validates RabbitMQ options since they will be validated by the amqp client. What it does is to make sure unsupported options are not accepted.
  • Documentation does not list all RabbitMQ options avaiable. Instead it points to the amqp client documentation where all options are described

Closes #1 and #4

@msaraiva msaraiva merged commit b27971d into master Apr 2, 2019
@msaraiva msaraiva deleted the ms-validation-docs branch April 2, 2019 19:54
@msaraiva msaraiva mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msaraiva @josevalim