Skip to content

Commit

Permalink
Do not fallback to string on failure app, easier for debugging, closes
Browse files Browse the repository at this point in the history
  • Loading branch information
josevalim committed Jan 24, 2012
1 parent b885240 commit 477d9fb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/devise/failure_app.rb
Expand Up @@ -64,7 +64,7 @@ def i18n_message(default = nil)

if message.is_a?(Symbol)
I18n.t(:"#{scope}.#{message}", :resource_name => scope,
:scope => "devise.failure", :default => [message, message.to_s])
:scope => "devise.failure", :default => [message])
else
message.to_s
end
Expand Down
4 changes: 2 additions & 2 deletions test/failure_app_test.rb
Expand Up @@ -52,8 +52,8 @@ def call_failure(env_params={})
end

test 'uses the proxy failure message as symbol' do
call_failure('warden' => OpenStruct.new(:message => :test))
assert_equal 'test', @request.flash[:alert]
call_failure('warden' => OpenStruct.new(:message => :invalid))
assert_equal 'Invalid email or password.', @request.flash[:alert]
assert_equal 'http://test.host/users/sign_in', @response.second["Location"]
end

Expand Down

0 comments on commit 477d9fb

Please sign in to comment.