Rails has removed SecureRandom from ActiveSupport in Rails 3.2, deprecated #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated in 3.1 Since it has been deprecated, this patch favors SecureRandom on ActiveSupport::SecureRandom
|
+1 |
|
We don't even need the defined? check as ::SecureRandom is available since 1.8.7. We just need to require secure random at the top and use it! |
|
@josevalim, I adjusted the patch accordingly... I was aware that it's included since 1.8.7 but my original patch was to avoid situations like mine last night, I was working on my project, one minute all my 200+ test passing, another none were passing.. because I updated my rails repo which happens to get updated at the same time as I ran bundle update.. but I don't think anyone is still using ruby <1.8.7 and wants to dive in rails 3.1 |
|
Rails 3.0 and 3.1 does not even support < 1.8.7. :) |
josevalim
added a commit
that referenced
this pull request
May 24, 2011
Rails has removed SecureRandom from ActiveSupport in Rails 3.2, deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails has remove SecureRandom from ActiveSupport in Rails 3.2, deprecated in 3.1
Since it has been deprecated, this patch favors SecureRandom on ActiveSupport::SecureRandom
Source: Commit on the rails repository