Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed require for google_oauth2 strategy #1441

Merged
merged 1 commit into from Nov 14, 2011

Conversation

cbuggle
Copy link
Contributor

@cbuggle cbuggle commented Nov 14, 2011

When including google_oauth2 strategy i ran into the error that the strategy could not be found.

Fixed that.

rafaelfranca added a commit that referenced this pull request Nov 14, 2011
fixed require for google_oauth2 strategy
@rafaelfranca rafaelfranca merged commit 03b56ff into heartcombo:master Nov 14, 2011
@josevalim
Copy link
Contributor

I don't think we should list all strategies. Maybe we should just try to require that file and rescue LoadError in case it doesn't work?

@rafaelfranca
Copy link
Collaborator

This is a better solution. What do you think @buggle? Could you provide a new pull request changing the way that we require the strategies?

@cbuggle
Copy link
Contributor Author

cbuggle commented Nov 16, 2011

sorry, quite busy at work. that's also why my pull request message was so brief.

After looking into it, i suppose it's caused by the mismatch of name "google-oauth2" and file "google_oauth2" of that strategy. Maybe we should just fix it right there...

Yetfor now i think this is a feasible solution, since we assure all major providers ( fb, twitter, google) work out of the box, and it is not that i introduced a whole new condition in that case statement just for google ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants