Flexible routing scopes

[excid3]

One of the things that I think could make Devise really handy, and understandable to newcomers is making scopes more flexible for constraints. Take this for example:

  devise_scope :user, lambda { |user| user.role == "admin"  } do
    root to: "admin#dashboard"
  end

or

  authenticated :user, lambda { |user| user.role == "admin"  } do
    root to: "admin#dashboard"
  end

Each of these is something pretty easily understood, and would provide a bit of clarity to the routes, and clean up any before_filters that you would use instead.

I've already got a start on an implementation of this, but wanted to know if this makes sense, or maybe there is already a way to do this with Devise as it stands.

[josevalim]

Yes, this looks great and makes sense for authenticate(d).

[excid3]

Is there a test for authenticate(d) I could use as a basis for testing these? And how does the implementation look? Anything I should clean up? Thanks!

[josevalim]

The implementation looks good, but could you please use (&& and ||) instead of and and or?

About the tests, you will need to define new routes here:

https://github.com/plataformatec/devise/blob/master/test/rails_app/config/routes.rb

And then add new tests for these routes inside this test case (where we keep tests for authenticated, unauthenticated, and so on):

https://github.com/plataformatec/devise/blob/master/test/integration/authenticatable_test.rb#L137

[excid3]

Thanks José! I added some tests and changed to the boolean logic like you mentioned. Anything else?

[josevalim]

Meeeeeeerged, thanks!

[excid3]

👍