Changes to support devise-neo4j #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to explicitly call .to_adapter in the tests. Could you please amend accordingly? Thank you! |
cheerfulstoic
referenced
this pull request
in neo4jrb/activegraph
Jun 6, 2014
Conflicts: lib/neo4j/active_node/labels.rb
|
Done! Tests ran fine locally. We'll see how Travis CI goes |
josevalim
pushed a commit
that referenced
this pull request
Jun 6, 2014
Changes to support devise-neo4j
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working to get the devise-neo4j gem working with the alpha version of neo4j. I've done the work in the neo4j gem to make it support an orm_adapter, but when I ran the devise tests I hit a couple of snags which needed to be addressed in the devise gem. They are:
Let me know if you have any questions about these changes!