Add dedicated reconfirmation mail #5087
Conversation
|
Hi @sakuraineed, thanks for your contribution. I'm more inclined to include a dedicated reconfirmation email, as mentioned in #4145. Do you want to change this pull request to do that instead? |
sakuraineed
force-pushed
the
add_dedicated_reconfirmation_mail_subject
branch
from
2115d29
to
33e921f
Compare
sakuraineed
changed the title
|
Hi @tegon, thanks for the comment. |
| @@ -117,8 +117,11 @@ def send_confirmation_instructions | |||
| generate_confirmation_token! | |||
| end | |||
|
|
|||
| opts = pending_reconfirmation? ? { to: unconfirmed_email } : { } | |||
| send_devise_notification(:confirmation_instructions, @raw_confirmation_token, opts) | |||
| if pending_reconfirmation? | |||
There was a problem hiding this comment.
What do you think about change this ifto:
params = {}
params[:to] = unconformed_email if pending_reconfirmation?
send_devise_notification(:confirmation_instructions, @raw_confirmation_token, params)There was a problem hiding this comment.
Thank you for your review.
I think send_devise_notification 's first argument must use each for calling Devise::Mailer#confirmation_instructions, reconfirmation_instructions
|
Is there anything I can do to help get this branch merged? |
This PR adds
:subject_keyto devise_mail options for reconfirmation mail subject.