Fixing deprecation warning for nil columns in Rails 4.2.beta1 #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
|
LGTM |
rafaelfranca
added a commit
that referenced
this pull request
Aug 25, 2014
Fixing deprecation warning for nil columns in Rails 4.2.beta1
dpickett
added a commit
to LaunchAcademy/preflight
that referenced
this pull request
Aug 27, 2014
deprecation warning w/ Simpleform addressed @ heartcombo/simple_form#1126
guigs
pushed a commit
to guigs/simple_form
that referenced
this pull request
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution for outstanding pull request #1094
The underlying issue is that simple_form calls
column_for_attributeon non-attribute inputs, for instance, password on a devise model. This results in a deprecation message from rails. The fix useshas_attribute?to ensure we don't call
column_for_attributeimproperly.