Support for maxlength on string inputs inferred from validation #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…takes presedence over database column metadata
| @@ -8,11 +8,12 @@ module SimpleForm | |||
|
|
|||
| def input | |||
| input_html_options[:size] ||= [limit, SimpleForm.default_input_size].compact.min | |||
| preferred_max_length = maximum_length_from_validation | |||
There was a problem hiding this comment.
I think that you can avoid this line changing the next to:
input_html_options[:maxlength] ||= maximum_length_from_validationThere was a problem hiding this comment.
Yes, you are correct. I'll make this change.
|
Hi mate, thank you for the pull request. I made some comments on the code. ❤️ |
|
No problem. Thanks for your feedback and prompt response! Let me know if you have any other suggestions. cheers. |
rafaelfranca
added a commit
that referenced
this pull request
Jul 21, 2011
Support for maxlength on string inputs inferred from validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
maxlengthattribute to string input fields that declarevalidates_length_of.Precedence is given to a field that declares a
validates_length_ofvalidation over the database column metadata limit.The driver for this was having to repeat maxlength in both the model and the form which caught me out a few times!
Feedback welcome.