Css class #289
Merged
Css class #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry! I just realized I forgot to add .compact before the join on line 38.. It should be: To prevent any trailing whitespace In case someone does do :html => {:class => nil}... |
|
Hey, no problem. Would you mind removing the other commit, and then you can also include this change in this commit? You should be able to use rebase / ammend to do that. (there is no need to close this pull request, just change the commits and do a forced push - Github will do the rest =D). Thanks. |
|
I think we're good to go here... Thanks! |
|
Here we go! Thanks for your work on that. |
carlosantoniodasilva
added a commit
that referenced
this pull request
Jul 26, 2011
Change form css class handling to only add the dom class when one is not given to the form call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added css_class method which will override the default model class if the user provides a css option. Passing in :html => {:class => nil} will result in only a "simple_form" class.