Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean hidden field uses name when :nested #620

Merged
merged 1 commit into from Jul 13, 2012
Merged

Boolean hidden field uses name when :nested #620

merged 1 commit into from Jul 13, 2012

Conversation

amiel
Copy link

@amiel amiel commented Jul 13, 2012

See #619

@rafaelfranca
Copy link
Collaborator

Could you add a test to see if the name of the hidden field is right without pass the :name option?

@amiel
Copy link
Author

amiel commented Jul 13, 2012

Yeah, no problem. I kind of figured that was covered by https://github.com/carnesmedia/simple_form/blob/a09403492658a6e508df9172cdf05370402b4e69/test/inputs/boolean_input_test.rb#L50

I was just about to double check with some manual testing.

@rafaelfranca
Copy link
Collaborator

Ahh, sorry I didn't look in the whole file. Thanks.

rafaelfranca added a commit that referenced this pull request Jul 13, 2012
…html

Boolean hidden field uses name when :nested
@rafaelfranca rafaelfranca merged commit 5548b2c into heartcombo:master Jul 13, 2012
@amiel
Copy link
Author

amiel commented Jul 13, 2012

Thanks for accepting. I just did some manual testing and found it working well.

Any idea when the next release will be?

@rafaelfranca
Copy link
Collaborator

I'm not sure, I need to discuss with @carlosantoniodasilva. What I was thinking is to backport some fixes to the 2.0.x branch (not created yet). But I'm fine with doing a 2.1.0 release now.

WDYT @carlosantoniodasilva?

@carlosantoniodasilva
Copy link
Member

Hey guys, sorry for the delay. We'll be working on a new release soon, not sure we'll backport something to release a 2.0.x, it's more likely that we'll bump to 2.1.0. Thanks!

@rafaelfranca
Copy link
Collaborator

@amiel I did the 2.0.3 some days ago

@amiel
Copy link
Author

amiel commented Oct 15, 2012

@rafaelfranca Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants