Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override form class with custom class! html attribute Implementation for #116 #639

Closed
wants to merge 1 commit into from

Conversation

a-chernykh
Copy link

No description provided.

@rafaelfranca
Copy link
Collaborator

Thank you for the pull request.

I don't like the use of a hash key with a !. But I don't have any idea how to make this now.

Lets see what the others think. cc @josevalim @carlosantoniodasilva @lucasmazza

@carlosantoniodasilva
Copy link
Member

Yeah, I kinda dislike the bang thing as well =(.

We've had a similar request (someone using the mailing I think), but for overriding hint class for a particular input instead. Perhaps we can come up with something that solves both in a similar approach (I know they're rather different code, but the idea persists).

Lets try to keep this on hold for a while to see if new ideas come up.

@AndreyChernyh thanks.

@ootoovak
Copy link

ootoovak commented Sep 5, 2012

I really should have checked to see if someone had tried this already. 😆 #657

Guess we are in need of a Wiki page showing a better solution.

@carlosantoniodasilva
Copy link
Member

@ootoovak a wiki page sounds a good option, you can go ahead and create one if you want with that code snippet and more examples if necessary, the wiki is open to everyone. Thanks!

@esad
Copy link

esad commented Feb 21, 2014

This is a great pull request. If bang is a problem, we can use :force_class or :only_class instead

@rafaelfranca
Copy link
Collaborator

I'm closing this one for the same reason as #657. If you want to have a class different for your forms you should not set in the global config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants