Allow to override form class with custom class! html attribute Implementation for #116 #639

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@andreychernih

No description provided.

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Aug 3, 2012

Collaborator

Thank you for the pull request.

I don't like the use of a hash key with a !. But I don't have any idea how to make this now.

Lets see what the others think. cc @josevalim @carlosantoniodasilva @lucasmazza

Collaborator

rafaelfranca commented Aug 3, 2012

Thank you for the pull request.

I don't like the use of a hash key with a !. But I don't have any idea how to make this now.

Lets see what the others think. cc @josevalim @carlosantoniodasilva @lucasmazza

@carlosantoniodasilva

This comment has been minimized.

Show comment Hide comment
@carlosantoniodasilva

carlosantoniodasilva Aug 11, 2012

Collaborator

Yeah, I kinda dislike the bang thing as well =(.

We've had a similar request (someone using the mailing I think), but for overriding hint class for a particular input instead. Perhaps we can come up with something that solves both in a similar approach (I know they're rather different code, but the idea persists).

Lets try to keep this on hold for a while to see if new ideas come up.

@andreychernyh thanks.

Collaborator

carlosantoniodasilva commented Aug 11, 2012

Yeah, I kinda dislike the bang thing as well =(.

We've had a similar request (someone using the mailing I think), but for overriding hint class for a particular input instead. Perhaps we can come up with something that solves both in a similar approach (I know they're rather different code, but the idea persists).

Lets try to keep this on hold for a while to see if new ideas come up.

@andreychernyh thanks.

@ootoovak

This comment has been minimized.

Show comment Hide comment
@ootoovak

ootoovak Sep 5, 2012

I really should have checked to see if someone had tried this already. 😆 #657

Guess we are in need of a Wiki page showing a better solution.

ootoovak commented Sep 5, 2012

I really should have checked to see if someone had tried this already. 😆 #657

Guess we are in need of a Wiki page showing a better solution.

@carlosantoniodasilva

This comment has been minimized.

Show comment Hide comment
@carlosantoniodasilva

carlosantoniodasilva Oct 16, 2012

Collaborator

@ootoovak a wiki page sounds a good option, you can go ahead and create one if you want with that code snippet and more examples if necessary, the wiki is open to everyone. Thanks!

Collaborator

carlosantoniodasilva commented Oct 16, 2012

@ootoovak a wiki page sounds a good option, you can go ahead and create one if you want with that code snippet and more examples if necessary, the wiki is open to everyone. Thanks!

@esad

This comment has been minimized.

Show comment Hide comment
@esad

esad Feb 21, 2014

This is a great pull request. If bang is a problem, we can use :force_class or :only_class instead

esad commented Feb 21, 2014

This is a great pull request. If bang is a problem, we can use :force_class or :only_class instead

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca Mar 20, 2014

Collaborator

I'm closing this one for the same reason as #657. If you want to have a class different for your forms you should not set in the global config.

Collaborator

rafaelfranca commented Mar 20, 2014

I'm closing this one for the same reason as #657. If you want to have a class different for your forms you should not set in the global config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment