Bug: Blockquote Style removes code block indentation

[mahtaran]

• I have verified that I am on the latest version of the Linter

Describe the Bug

When blockquote style is turned on, it will remove indentation inside code blocks.

How to Reproduce

Given the following example:

> Example blockquote
>Wrongly indented line
> 
> ```javascript
> function greet() {
>     console.log("Hello mom!")
> }
> ```

Expected Behaviour

> Example blockquote
> Wrongly indented line
> 
> ```javascript
> function greet() {
>     console.log("Hello mom!")
> }
> ```

Actual Behaviour

> Example blockquote
> Wrongly indented line
> 
> ```javascript
> function greet() {
> console.log("Hello mom!")
> }
> ```

Additional Context

I believe this issue could be resolved by defining an insideCodeBlock flag in updateBlockquoteLines which will skip any lines inside the code block.

[pjkaufman]

Hey @mahtaran . If we are saying saying that we are ignoring code blocks in blockquotes altogether, then we would add them to an ignore list. But if we are saying we still need to apply the blockqoute style to those lines then a flag would be needed.

It probably makes sense to just ignore code blocks in blockquotes because having no spaces would slowly remove all spaces inside the code block.

[mahtaran]

Yeah, I feel like ignoring any content within code blocks might be the best solution.

[pjkaufman]

It will ignore the blockquote indicators as well. So that means it would end up being something like the following to the rule:

> Example blockquote
>Wrongly indented line
> 
> {CODE_BLOCK}

[pjkaufman]

Does that sound like the intended result? It will replace {CODE_BLOCK} with its original content.

[mahtaran]

Yes! Perhaps it could still check the indentation before the opening backticks, but apart from that I'd leave it up to the user how they want to indent their code.

[pjkaufman]

I think it would still allow for the opening backticks, but the rest would be unaffected.

[pjkaufman]

I believe I have a fix. It just needs to finish running the CI and if that passes, I will go ahead and merge it.

[pjkaufman]

I have merged the change. So this issue should be fixed on master and in the next release. Please let us know if it is not working in either case.