Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: <!-- linter-disable --> can only be used once for V1.15.0 #733

Closed
1 task
wenbopeng opened this issue May 25, 2023 · 5 comments · Fixed by #736
Closed
1 task

Bug: <!-- linter-disable --> can only be used once for V1.15.0 #733

wenbopeng opened this issue May 25, 2023 · 5 comments · Fixed by #736
Assignees
Labels
bug Something isn't working reproducible resolution/update-made A change has been made that should resolve this issue or request

Comments

@wenbopeng
Copy link

##<!-- linter-disable --> can only be used once for V1.15.0

If <!-- linter-disable --> is used more than twice, the result will be confused

Example to reproduce issue with

content

<!-- linter-disable -->

$$
abc
$$
{#eq:a}

<!-- linter-enable -->

content

<!-- linter-disable -->

$$
abc
$$
{#eq:b}

<!-- linter-enable -->

content

Expected Behavior

Expected output if applicable:

Same as Example

Screenshots

image.png

Device

  • [ x] Desktop V1.15.0
  • Mobile
@wenbopeng wenbopeng added the bug Something isn't working label May 25, 2023
@pjkaufman
Copy link
Collaborator

@wenbopeng , thanks for reporting this.

Please provide your data.json. This looks to be an issue with custom ignore and some rule interacting with each other.

@pjkaufman
Copy link
Collaborator

I will have to take a closer look at this. I tried this out and can reproduce.

The issue is likely related to using the {#eq:a} and {#eq:b} values as they look similar to some of the underlying ignore logic. I will need to double check which rule is causing the issue on my device, but it could be the same one you are encountering.

@pjkaufman
Copy link
Collaborator

That syntax may be causing an unexpected and early stop for what values should be added back which could be a problem. I will need to do a closer inspection of the logic to be sure.

@pjkaufman
Copy link
Collaborator

The issue is with 1 or more custom ignore ranges being present. They were being identified correctly, but were being replaced in the wrong order which caused the issue. I plan to patch this this morning.

@pjkaufman
Copy link
Collaborator

This should be fixed on master now and it should be in the patch that should go out shortly. Please let us know if the issue persists after the next release/the patch.

@pjkaufman pjkaufman added the resolution/update-made A change has been made that should resolve this issue or request label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reproducible resolution/update-made A change has been made that should resolve this issue or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants