Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Wikilinks get included when moving tags to frontmatter #952

Closed
2 of 3 tasks
jericjan opened this issue Nov 28, 2023 · 4 comments · Fixed by #953
Closed
2 of 3 tasks

Bug: Wikilinks get included when moving tags to frontmatter #952

jericjan opened this issue Nov 28, 2023 · 4 comments · Fixed by #953
Assignees
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature resolution/update-made A change has been made that should resolve this issue or request

Comments

@jericjan
Copy link

  • I have verified that I am on the latest version of the Linter

Describe the Bug

If tags in the body that have a wikilink right next to it, this will cause the wikilink to also be placed in the tags frontmatter.

How to Reproduce

This

---
title: Note
Date: 2023-10-24T23:00:00+08:00
lastMod: 2023-11-28T17:36:29+08:00
---

#tag![[image.png]]

turns into

---
title: Note
Date: 2023-10-24T23:00:00+08:00
lastMod: 2023-11-28T17:36:59+08:00
tags: [tag![[image.png]]]
---

#tag{WIKI_LINK_PLACEHOLDER}

Expected Behavior

It shouldn't include that wikilink at all. If this is intended behavior, then an option to disable this would be nice.

---
title: Note
Date: 2023-10-24T23:00:00+08:00
lastMod: 2023-11-28T17:36:59+08:00
tags: [tag]
---

#tag![[image.png]]

Device

  • Desktop
  • Mobile
@jericjan jericjan added the bug Something isn't working label Nov 28, 2023
@pjkaufman
Copy link
Collaborator

Hey @jericjan . I am seeing something weird in the example that looks to be the problem. However it may be valid and I am just not aware of it.

Tags should have a space between their ending and other content from my understanding. Could you explain why the wiki link is attached to the tag?

@pjkaufman
Copy link
Collaborator

Looks like for some reason this is considered valid for tags (I thought they needed to end in whitespace). I will have to account for that.

@pjkaufman pjkaufman added the obsidian Obsidian specific syntax issue or feature label Nov 28, 2023
@pjkaufman
Copy link
Collaborator

I believe that I have a fix for this. It was a simple regex tweak and should go out in the next release.

@pjkaufman pjkaufman self-assigned this Nov 28, 2023
@pjkaufman pjkaufman added the resolution/update-made A change has been made that should resolve this issue or request label Nov 28, 2023
@pjkaufman
Copy link
Collaborator

The change for this should be merged into master and go out with the next release. Please let us know if either has any problems. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working obsidian Obsidian specific syntax issue or feature resolution/update-made A change has been made that should resolve this issue or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants