Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve specificity issue with banner background color #146

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 15, 2020

Description

The home page banner (header area including logo and navigation) has a blue background colour. I applied it using the .home class. However, the home page in WordPress has both .home and .page classes, so this rule was being overridden by the banner colour style for pages. This PR addresses this issue.

Steps to test

Review menu and home menu components and confirm that the banner areas have the correct background colours:

Additional information

Not applicable.

Related issues

Not applicable.

@greatislander greatislander added the enhancement New feature or request label Jan 15, 2020
@greatislander greatislander added this to the 1.0.0-alpha.5 milestone Jan 15, 2020
@greatislander greatislander self-assigned this Jan 15, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 15, 2020
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 15, 2020
@greatislander greatislander marked this pull request as ready for review January 15, 2020 20:14
@greatislander greatislander moved this from To Do to In Progress in Cooperative Resource Library 1.0.0 Jan 15, 2020
@greatislander greatislander added bug Something isn't working and removed enhancement New feature or request labels Jan 15, 2020
@greatislander greatislander merged commit 0f68bde into dev Jan 15, 2020
Cooperative Resource Library 1.0.0 automation moved this from In Progress to Done Jan 15, 2020
Pinecone 1.0.0 automation moved this from In progress to Done Jan 15, 2020
@greatislander greatislander deleted the fix/home-banner branch January 15, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant