Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search variant for home page (resolve #162) #164

Merged
merged 4 commits into from
Jan 17, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 17, 2020

Description

Adds large, full-width search component for home page.

Steps to test

Review component:

Additional information

Not applicable.

Related issues

@greatislander greatislander marked this pull request as ready for review January 17, 2020 00:42
@greatislander greatislander self-assigned this Jan 17, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 17, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 17, 2020
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 17, 2020
@greatislander greatislander added this to the 1.0.0-alpha.7 milestone Jan 17, 2020
@greatislander greatislander moved this from To Do to Review in progress in Cooperative Resource Library 1.0.0 Jan 17, 2020
@greatislander greatislander moved this from In progress to Review in progress in Pinecone 1.0.0 Jan 17, 2020
@cherylhjli
Copy link

I think the light blue border in pressed state might have to be a bit thicker since the box is so big! can we up it to 2 or 3 px width?
Also, can we add a grey search icon back into the field, on the left, like they are in the mockups?
https://xd.adobe.com/view/5cbb2c96-51ce-4b66-4604-15c35058ee9c-2a8a/screen/332ea80c-bd47-414c-af1b-31c993458100/00-Desktop-components-16

I think this is necessary in the large search bars (but not the small ones) since our eye tends to travel down the left side of the page first when scanning, and since the search bar is so wide in this case, it may not be obvious to users scanning down the page quickly that it's a search box.

@netlify
Copy link

netlify bot commented Jan 17, 2020

Deploy preview for pinecone ready!

Built with commit db2928e

https://deploy-preview-164--pinecone.netlify.com

@greatislander
Copy link
Collaborator Author

@cherylhjli Fixed ↑

@greatislander
Copy link
Collaborator Author

@cherylhjli In terms of border width, you mean focused state (not pressed)?

Cooperative Resource Library 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 17, 2020
Pinecone 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 17, 2020
@greatislander greatislander merged commit 9300c58 into dev Jan 17, 2020
Cooperative Resource Library 1.0.0 automation moved this from Reviewer approved to Done Jan 17, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Jan 17, 2020
@greatislander greatislander deleted the add/search-variants branch January 17, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Molecule: search variants
2 participants