Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add home layout and info cards #170

Merged
merged 16 commits into from
Jan 20, 2020
Merged

feat: add home layout and info cards #170

merged 16 commits into from
Jan 20, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 20, 2020 •
edited

Description

Adds home layout and info card component; standardizes mobile menu toggle button.

Steps to test

Review components:

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Jan 20, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 20, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 20, 2020
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 20, 2020
@greatislander greatislander added this to the 1.0.0-alpha.7 milestone Jan 20, 2020
@greatislander greatislander marked this pull request as ready for review January 20, 2020 17:45
@netlify
Copy link

netlify bot commented Jan 20, 2020 •
edited

Deploy preview for pinecone ready!

Built with commit fd6a1f7

https://deploy-preview-170--pinecone.netlify.com

@greatislander greatislander moved this from To Do to Review in progress in Cooperative Resource Library 1.0.0 Jan 20, 2020
Cooperative Resource Library 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 20, 2020
Pinecone 1.0.0 automation moved this from In progress to Reviewer approved Jan 20, 2020
@cherylhjli
Copy link

Info card:

  • is there a way to reduce the padding on the top of the card, as close as possible to the padding on the bottom so the 4 sides are even? i'm ok if we have to reduce the focus area of the close icon to be smaller and reduce some padding there

Home page

  • looks super great!!!!!

@cherylhjli
Copy link

oh one thing about the home page:
the recently published section has the 4 cards stretched out over the whole column. Is it possible to have the cards the same width as the cards above under most viewed, and leave that right column blank?

@greatislander greatislander merged commit b57d3ab into dev Jan 20, 2020
Cooperative Resource Library 1.0.0 automation moved this from Reviewer approved to Done Jan 20, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Jan 20, 2020
@greatislander greatislander deleted the add/home-layout branch January 20, 2020 19:43
@greatislander greatislander mentioned this pull request Feb 13, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

@cherylhjli cherylhjli Awaiting requested review from cherylhjli

@dayotte dayotte Awaiting requested review from dayotte

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
Pinecone 1.0.0
  
Done
Cooperative Resource Library 1.0.0
  
Done
Milestone
1.0.0-alpha.7
Development

Successfully merging this pull request may close these issues.

Layout: home page Molecule: info card
3 participants
@greatislander @cherylhjli @jhung