Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add footer (resolves #172) #176

Merged
merged 3 commits into from
Jan 21, 2020
Merged

feat: add footer (resolves #172) #176

merged 3 commits into from
Jan 21, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 20, 2020

Description

Adds footer.

Steps to test

Review component: https://deploy-preview-176--pinecone.netlify.com/components/detail/home.html

Additional information

Not applicable.

Related issues

@greatislander greatislander added this to the 1.0.0-alpha.8 milestone Jan 20, 2020
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 20, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 20, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 20, 2020
@greatislander greatislander self-assigned this Jan 20, 2020
@greatislander greatislander moved this from In progress to Review in progress in Pinecone 1.0.0 Jan 20, 2020
@greatislander greatislander moved this from To Do to Review in progress in Cooperative Resource Library 1.0.0 Jan 20, 2020
@netlify
Copy link

netlify bot commented Jan 20, 2020

Deploy preview for pinecone ready!

Built with commit 46252a7

https://deploy-preview-176--pinecone.netlify.com

Copy link
Contributor

@jhung jhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the footer can be simplified - just a Footer container with 5 links. I don't think there's any need to give any additional semantics structure to the content there.

src/components/02-molecules/11-footer/footer.njk Outdated Show resolved Hide resolved
src/components/02-molecules/11-footer/footer.njk Outdated Show resolved Hide resolved
src/components/02-molecules/11-footer/footer.njk Outdated Show resolved Hide resolved
Cooperative Resource Library 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 21, 2020
Pinecone 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 21, 2020
@greatislander greatislander merged commit 2b23d3e into dev Jan 21, 2020
Cooperative Resource Library 1.0.0 automation moved this from Reviewer approved to Done Jan 21, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Jan 21, 2020
@greatislander greatislander deleted the add/footer branch January 21, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Molecule: add footer
2 participants