fix: improve home semantics #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
moved this from To Do
to Review in progress
in Cooperative Resource Library 1.0.0
|
Deploy preview for pinecone ready! Built with commit 803d91a |
jhung
requested changes
Jan 22, 2020
|
@jhung Fixed menu component. |
Cooperative Resource Library 1.0.0
automation
moved this from Review in progress
to Reviewer approved
Jan 22, 2020
jhung
approved these changes
Jan 22, 2020
Cooperative Resource Library 1.0.0
automation
moved this from Reviewer approved
to Done
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses labelled
<section>elements for improved home page semantics; removes<hr />elements in favour of pure CSS solution for horizontal dividers.Also: splits typography styles into partials.
Steps to test
Review layout: https://deploy-preview-179--pinecone.netlify.com/components/preview/home.html
Additional information
Resolves changes requested in platform-coop-toolkit/coop-library#151 (review).
Related issues
Not applicable.