-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve home semantics #179
Conversation
Deploy preview for pinecone ready! Built with commit 803d91a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hovering over a top navigation item with current page styling causes illegible text (a light grey text on a white background). This issue does not appear in the Menu component and may be specific to the Home page.
@jhung Fixed menu component. |
Description
Uses labelled
<section>
elements for improved home page semantics; removes<hr />
elements in favour of pure CSS solution for horizontal dividers.Also: splits typography styles into partials.
Steps to test
Review layout: https://deploy-preview-179--pinecone.netlify.com/components/preview/home.html
Additional information
Resolves changes requested in platform-coop-toolkit/coop-library#151 (review).
Related issues
Not applicable.