Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve home semantics #179

Merged
merged 6 commits into from
Jan 22, 2020
Merged

fix: improve home semantics #179

merged 6 commits into from
Jan 22, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 21, 2020

Description

Uses labelled <section> elements for improved home page semantics; removes <hr /> elements in favour of pure CSS solution for horizontal dividers.

Also: splits typography styles into partials.

Steps to test

Review layout: https://deploy-preview-179--pinecone.netlify.com/components/preview/home.html

Additional information

Resolves changes requested in platform-coop-toolkit/coop-library#151 (review).

Related issues

Not applicable.

@greatislander greatislander added this to the 1.0.0-alpha.8 milestone Jan 21, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 21, 2020
@greatislander greatislander moved this from In progress to Review in progress in Pinecone 1.0.0 Jan 21, 2020
@greatislander greatislander added this to To Do in Cooperative Resource Library 1.0.0 via automation Jan 21, 2020
@greatislander greatislander moved this from To Do to Review in progress in Cooperative Resource Library 1.0.0 Jan 21, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 21, 2020
@greatislander greatislander self-assigned this Jan 21, 2020
@netlify
Copy link

netlify bot commented Jan 21, 2020

Deploy preview for pinecone ready!

Built with commit 803d91a

https://deploy-preview-179--pinecone.netlify.com

Copy link
Contributor

@jhung jhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hovering over a top navigation item with current page styling causes illegible text (a light grey text on a white background). This issue does not appear in the Menu component and may be specific to the Home page.

src/components/03-layouts/04-home/home.njk Outdated Show resolved Hide resolved
src/components/03-layouts/04-home/home.njk Outdated Show resolved Hide resolved
@greatislander
Copy link
Collaborator Author

@jhung Fixed menu component.

Cooperative Resource Library 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 22, 2020
Pinecone 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 22, 2020
@greatislander greatislander merged commit e3cf9fd into dev Jan 22, 2020
Cooperative Resource Library 1.0.0 automation moved this from Reviewer approved to Done Jan 22, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Jan 22, 2020
@greatislander greatislander deleted the fix/home-semantics branch January 22, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants