Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore functionality to nested checkboxes (resolves #210) #212

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 29, 2020

Description

This PR restores click functionality to the parent checkbox of nested checkboxes in the filter list.

Steps to test

  1. View the Archive component: https://deploy-preview-212--pinecone.netlify.com/components/preview/archive
  2. Expand "Goals" in the filter list.
  3. Check and uncheck one of the parent checkboxes (e.g. 'Build a co-op').

Expected behavior: The parent checkboxe's state changes, and children are checked or unchecked as appropriate.

Additional information

Not applicable.

Related issues

@greatislander greatislander added the bug Something isn't working label Jan 29, 2020
@greatislander greatislander self-assigned this Jan 29, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Jan 29, 2020
@greatislander greatislander added this to To do in Cooperative Resource Library 1.0.0 via automation Jan 29, 2020
@greatislander greatislander moved this from To do to In progress in Cooperative Resource Library 1.0.0 Jan 29, 2020
@greatislander greatislander added this to the 1.0.0-alpha.10 milestone Jan 29, 2020
@greatislander greatislander moved this from In progress to Review in progress in Cooperative Resource Library 1.0.0 Jan 29, 2020
@netlify
Copy link

netlify bot commented Jan 29, 2020

Deploy preview for pinecone ready!

Built with commit 51def71

https://deploy-preview-212--pinecone.netlify.com

Cooperative Resource Library 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 29, 2020
Pinecone 1.0.0 automation moved this from In progress to Reviewer approved Jan 29, 2020
@greatislander greatislander merged commit af70718 into dev Jan 29, 2020
Cooperative Resource Library 1.0.0 automation moved this from Reviewer approved to Done Jan 29, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Jan 29, 2020
@greatislander greatislander deleted the fix/filter-list-regression branch January 29, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Regression: checking top-level filter checkbox no longer works
2 participants