feat: add search results and dialog with input (resolves #207) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
changed the title
greatislander
moved this from To do
to In progress
in Cooperative Resource Library 1.0.0
|
Deploy preview for pinecone ready! Built with commit 9b30444 |
7 tasks
|
Spacing is good. H1: Save Search Input field label: Name of saved search: CTA: |
|
@cherylhjli Back to you for final review. |
cherylhjli
approved these changes
Feb 19, 2020
Cooperative Resource Library 1.0.0
automation
moved this from In progress
to Reviewer approved
Feb 19, 2020
greatislander
changed the title
jhung
requested changes
Feb 19, 2020
| if ( this.config.input && this.config.inputLabel ) { | ||
| innerHtml += '<div class="input-group">'; | ||
| innerHtml += `<label for="${this.config.input}">${this.config.inputLabel}</label>`; | ||
| innerHtml += `<input id="${this.config.input}" type="text" name="${this.config.input}" />`; |
There was a problem hiding this comment.
Couple questions (more design related):
- Should there be an explicit close button on the dialog? My expectation is there should be one.
- If the input field is mandatory, I think the initial focus should be on the input field (or second in the tab order if a close button is added as per comment above).
- If the input field is optional, the initial focus can be on "No, don't save".
Thoughts?
There was a problem hiding this comment.
* Should there be an explicit close button on the dialog? My expectation is there should be one.
I thought we had discussed this at some point, but my thinking was that we shouldn't. I was thinking this for a few reasons:
- The modal is essentially an enhanced version of a native
confirm()dialog, which doesn't provide a close button; you either confirm or cancel (hitting the esc key is effectively the same as cancelling the operation). - This guide doesn't mention adding a close button other than the cancel button: https://guide.inclusivedesign.ca/tools/AccessibleDevelopmentTools.html
- In this case, where a user may have entered text, closing the dialog with a neutral close button as opposed to a specific cancel button might lead some users to think that if they invoke the dialog again, their input will be preserved.
* If the input field is mandatory, I think the initial focus should be on the input field (or second in the tab order if a close button is added as per comment above).
Agreed! Fixed in c220f9b.
* If the input field is optional, the initial focus can be on "No, don't save".
Cooperative Resource Library 1.0.0
automation
moved this from Reviewer approved
to Done
Feb 19, 2020
Cooperative Resource Library 1.0.0
automation
moved this from Done
to Review in progress
Feb 19, 2020
greatislander
added a commit
that referenced
this pull request
Feb 19, 2020
greatislander
added a commit
that referenced
this pull request
Feb 19, 2020
greatislander
moved this from Review in progress
to Done
in Cooperative Resource Library 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps to test
Review dialog component and search results layout.
Additional information
Not applicable.
Related issues