Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML examples should be valid html #287

Closed
erictheise opened this issue Mar 23, 2020 · 2 comments · Fixed by #288
Closed

HTML examples should be valid html #287

erictheise opened this issue Mar 23, 2020 · 2 comments · Fixed by #288
Assignees
Labels
enhancement New feature or request

Comments

@erictheise
Copy link
Member

In the case of Checkboxes and Radio Buttons the example code in the HTML section displays multiple inputs having the same id

<ul class="input-group">
    <li><input id="radio" type="radio" name="radio" value="radio" /><label for="radio">Radio Button</label></li>
    <li><input id="radio" type="radio" name="radio" value="radio" checked /><label for="radio">Radio Button</label></li>
    <li><input id="radio" type="radio" name="radio" value="radio" disabled /><label for="radio">Radio Button</label></li>
</ul>

and so the examples don't actually work. Clicking the second checkbox toggles the first. It is impossible to select the second radio button once the first has been selected.

I haven't looked behind the scenes to see how the examples are generated but they should contain unique indices and exhibit correct behavior for the input type.

@erictheise erictheise added the enhancement New feature or request label Mar 23, 2020
@greatislander greatislander added this to To do in Pinecone 1.0.0 via automation Mar 25, 2020
@greatislander greatislander moved this from To do to In progress in Pinecone 1.0.0 Mar 25, 2020
@greatislander greatislander added this to the 1.0.0-alpha.12 milestone Mar 25, 2020
@greatislander greatislander linked a pull request Mar 25, 2020 that will close this issue
2 tasks
@greatislander
Copy link
Collaborator

Should be resolved in #240.

Pinecone 1.0.0 automation moved this from In progress to Done Apr 16, 2020
@erictheise
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants