-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add global navigation (resolves #308) #309
Conversation
Deploy preview for pinecone ready! Built with commit 966946f |
@cherylhjli fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cherylhjli What is the intended behaviour for the mobile breakpoint? Currently the global navigation does not stack properly and items are hidden:
@cherylhjli, I find the use of the pine tree logo twice confusing as they are visually similar and in roughly the same screen position (especially on mobile) - but do different things. What do you think of the idea of putting the global navigation prominently above the footer? |
@jhung intended behaviour for mobile is that this global menu goes away, so I think what Ned has there is what is specced in the design. We tried a dropdown version, but it didn't quite work. The resource library actually is supposed to have its own logo now to avoid the quadruple pine situation - it's in the v03 core screens file! |
This is addressed here: #310 |
Description
Adds global navigation molecule.
Steps to test
Review Global Navigation component.
Additional information
Not applicable.
Related issues