Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global navigation (resolves #308) #309

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Apr 14, 2020

Description

Adds global navigation molecule.

Steps to test

Review Global Navigation component.

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Apr 14, 2020
@greatislander greatislander added the enhancement New feature or request label Apr 14, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0 via automation Apr 14, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone Apr 14, 2020
@netlify
Copy link

netlify bot commented Apr 14, 2020

Deploy preview for pinecone ready!

Built with commit 966946f

https://deploy-preview-309--pinecone.netlify.app

@greatislander greatislander changed the title feat: add global navigation (resolves feat: add global navigation (resolves #308) Apr 15, 2020
@greatislander greatislander marked this pull request as ready for review April 15, 2020 19:36
@cherylhjli
Copy link

Screen Shot 2020-04-15 at 4 13 50 PM

It's looking a little funky for me!

@greatislander
Copy link
Collaborator Author

@cherylhjli fixed now

Pinecone 1.0.0 automation moved this from In progress to Reviewer approved Apr 15, 2020
jhung
jhung previously requested changes Apr 16, 2020
Copy link
Contributor

@jhung jhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cherylhjli What is the intended behaviour for the mobile breakpoint? Currently the global navigation does not stack properly and items are hidden:

image

src/components/molecules/global-nav/global-nav.njk Outdated Show resolved Hide resolved
Pinecone 1.0.0 automation moved this from Reviewer approved to Review in progress Apr 16, 2020
@jhung
Copy link
Contributor

jhung commented Apr 16, 2020

@cherylhjli, I find the use of the pine tree logo twice confusing as they are visually similar and in roughly the same screen position (especially on mobile) - but do different things.

What do you think of the idea of putting the global navigation prominently above the footer?

@cherylhjli
Copy link

@jhung intended behaviour for mobile is that this global menu goes away, so I think what Ned has there is what is specced in the design. We tried a dropdown version, but it didn't quite work.

The resource library actually is supposed to have its own logo now to avoid the quadruple pine situation - it's in the v03 core screens file!

@greatislander
Copy link
Collaborator Author

I find the use of the pine tree logo twice confusing as they are visually similar and in roughly the same screen position (especially on mobile) - but do different things.

This is addressed here: #310

Pinecone 1.0.0 automation moved this from Review in progress to Reviewer approved Apr 16, 2020
@greatislander greatislander merged commit 11ecf64 into dev Apr 16, 2020
Pinecone 1.0.0 automation moved this from Reviewer approved to Done Apr 16, 2020
@greatislander greatislander deleted the add/global-nav branch April 16, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Global navigation bar
3 participants