fix: ensure that current menu text is visible (resolves #275) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pinecone ready! Built with commit 6baf0b5 |
|
I believe the designs don't have a black background for the current page... am I missing some context for this change? |
|
@cherylhjli I realize what was happening— it was inheriting background colour from the mobile menu. Fixed now, let me know if there's any outstanding issues. |
greatislander
moved this from Review in progress
to In progress
in Pinecone 1.0.0-beta.1
cherylhjli
approved these changes
May 15, 2020
greatislander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves issue where text of current menu item wasn't visible on menu component.
Steps to test
Review component: https://deploy-preview-346--pinecone.netlify.app/components/detail/menu--default.html
Additional information
Not applicable.
Related issues
Resolves #275.