fix: prevent top level checkbox overlap (fixes #292) #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pinecone ready! Built with commit 1b08c3a |
|
Looks great!
|
|
@cherylhjli That's a separate task, I think— it would involve work on this custom element plus radio buttons and checkboxes. If you could open a ticket for it I could tackle it at some point in the future. |
cherylhjli
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where a top-level checkbox in the filter list would be overlapped by the disclosure button.
Steps to test
Expected behavior: Goals → Build a Platform or Protocol should wrap instead of being overlapped by the disclosure button as it is here: https://resources.platform.coop/resources/
Additional information
Not applicable.
Related issues
Fixes #292.