feat: tabs (resolves #337) #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pinecone ready! Built with commit bc06a98 |
|
Looks great! For the desktop version can a grey line be added on the bottom of the component? like this: |
|
@cherylhjli Ready for review. |
|
Default looks great! I realized I didn't supply inverse designs, here they are: |
|
@cherylhjli Inverse styles are ready for review. |
|
any chance the tabs on desktop could span the entire length of the page? |
|
@cherylhjli done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tabs.
Steps to test
Review component: https://deploy-preview-350--pinecone.netlify.app/components/preview/tabs
Additional information
Based on https://github.com/zachleat/seven-minute-tabs and, by extension, https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html.
Related issues
Resolves #337.