Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add comprehensive Django support to inputs #376

Merged
merged 8 commits into from
Jun 2, 2020
Merged

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jun 2, 2020

Description

Adds support for alternative markup for all form inputs (based on Django conventions).

  • Generic inputs (text, password, email, url, tel, number)
  • Text areas
  • Selects
  • Checkboxes
  • Custom checkboxes (with indeterminate state)
  • Radio buttons

Steps to test

  1. Visit deploy preview.
  2. Test all form elements, as well as filter UI and dialog with input.

Expected behavior: Everything works and looks as expected.

Additional information

Nested checkboxes now require an .input--parent class on the parent checkbox. See: https://github.com/platform-coop-toolkit/pinecone/pull/376/files#diff-03a19b9935aa0f00880bc05b3fc94effR47

Related issues

@greatislander greatislander self-assigned this Jun 2, 2020
@greatislander greatislander added the enhancement New feature or request label Jun 2, 2020
@greatislander greatislander added this to the 1.0.0-beta.2 milestone Jun 2, 2020
@greatislander greatislander added this to In progress in Pinecone 1.0.0-beta.2 via automation Jun 2, 2020
@greatislander greatislander changed the title feat: add comprehensive Django support to inputs feat: BREAKING add comprehensive Django support to inputs Jun 2, 2020
@greatislander greatislander changed the title feat: BREAKING add comprehensive Django support to inputs feat!: add comprehensive Django support to inputs Jun 2, 2020
@netlify
Copy link

netlify bot commented Jun 2, 2020

Deploy preview for pinecone ready!

Built with commit f5cae60

https://deploy-preview-376--pinecone.netlify.app

@greatislander greatislander marked this pull request as ready for review June 2, 2020 16:49
Pinecone 1.0.0-beta.2 automation moved this from In progress to Reviewer approved Jun 2, 2020
@jhung
Copy link
Contributor

jhung commented Jun 2, 2020

Functionally it's fine. I filed two new bugs I found in testing which can be addressed separately / later.

#378
#377

@greatislander greatislander merged commit 675b165 into dev Jun 2, 2020
Pinecone 1.0.0-beta.2 automation moved this from Reviewer approved to Done Jun 2, 2020
@greatislander greatislander deleted the improve-inputs branch June 2, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Multi-select Pinecone lacks comprehensive support for Django form markup
3 participants