Allow working without ctypes #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
requested review from
gaborbernat,
ofek,
Julian and
RonnyPfannschmidt
as code owners
youknowone
force-pushed
the
windows-ctypes
branch
2 times, most recently
from
a15c2d9
to
7adab13
Compare
youknowone
changed the title
youknowone
force-pushed
the
windows-ctypes
branch
4 times, most recently
from
e6d0bc1
to
a6e2dfd
Compare
|
Thanks! I added test for all platforms to prevent regression because other platforms are already safe to work without ctypes |
gaborbernat
approved these changes
Apr 21, 2024
auto-merge was automatically disabled
April 21, 2024 23:27
Head branch was pushed to by a user without write access
youknowone
force-pushed
the
windows-ctypes
branch
from
a6e2dfd
to
a6376be
Compare
RonnyPfannschmidt
approved these changes
Apr 22, 2024
alicejli
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
May 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [platformdirs](https://togithub.com/platformdirs/platformdirs) | `==4.1.0` -> `==4.2.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>platformdirs/platformdirs (platformdirs)</summary> ### [`v4.2.1`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.1) [Compare Source](https://togithub.com/platformdirs/platformdirs/compare/4.2.0...4.2.1) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Switch to ruff for formatting and use codespell and docformatter by [@​gaborbernat](https://togithub.com/gaborbernat) in [platformdirs/platformdirs#261 - Use hatch over tox by [@​gaborbernat](https://togithub.com/gaborbernat) in [platformdirs/platformdirs#262 - chore: various minor fixes by [@​deronnax](https://togithub.com/deronnax) in [platformdirs/platformdirs#263 - chore: update dead Microsoft's known folders documentation link by [@​deronnax](https://togithub.com/deronnax) in [platformdirs/platformdirs#267 - Allow working without ctypes by [@​youknowone](https://togithub.com/youknowone) in [platformdirs/platformdirs#275 #### New Contributors - [@​deronnax](https://togithub.com/deronnax) made their first contribution in [platformdirs/platformdirs#263 - [@​youknowone](https://togithub.com/youknowone) made their first contribution in [platformdirs/platformdirs#275 **Full Changelog**: platformdirs/platformdirs@4.2.0...4.2.1 ### [`v4.2.0`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.0) [Compare Source](https://togithub.com/platformdirs/platformdirs/compare/4.1.0...4.2.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Fix 2 typos about XDG_DATA_DIR by [@​Freed-Wu](https://togithub.com/Freed-Wu) in [platformdirs/platformdirs#256 - Add convenience methods to `PlatformDirsAPI` that allow iterating over both user and site dirs/paths. by [@​SpaceshipOperations](https://togithub.com/SpaceshipOperations) in [platformdirs/platformdirs#258 #### New Contributors - [@​SpaceshipOperations](https://togithub.com/SpaceshipOperations) made their first contribution in [platformdirs/platformdirs#258 **Full Changelog**: platformdirs/platformdirs@4.1.0...4.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>
This was referenced May 20, 2024
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
May 22, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [platformdirs](https://togithub.com/platformdirs/platformdirs) | `==4.1.0` -> `==4.2.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>platformdirs/platformdirs (platformdirs)</summary> ### [`v4.2.1`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.1) [Compare Source](https://togithub.com/platformdirs/platformdirs/compare/4.2.0...4.2.1) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Switch to ruff for formatting and use codespell and docformatter by [@​gaborbernat](https://togithub.com/gaborbernat) in [platformdirs/platformdirs#261 - Use hatch over tox by [@​gaborbernat](https://togithub.com/gaborbernat) in [platformdirs/platformdirs#262 - chore: various minor fixes by [@​deronnax](https://togithub.com/deronnax) in [platformdirs/platformdirs#263 - chore: update dead Microsoft's known folders documentation link by [@​deronnax](https://togithub.com/deronnax) in [platformdirs/platformdirs#267 - Allow working without ctypes by [@​youknowone](https://togithub.com/youknowone) in [platformdirs/platformdirs#275 #### New Contributors - [@​deronnax](https://togithub.com/deronnax) made their first contribution in [platformdirs/platformdirs#263 - [@​youknowone](https://togithub.com/youknowone) made their first contribution in [platformdirs/platformdirs#275 **Full Changelog**: platformdirs/platformdirs@4.2.0...4.2.1 ### [`v4.2.0`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.0) [Compare Source](https://togithub.com/platformdirs/platformdirs/compare/4.1.0...4.2.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Fix 2 typos about XDG_DATA_DIR by [@​Freed-Wu](https://togithub.com/Freed-Wu) in [platformdirs/platformdirs#256 - Add convenience methods to `PlatformDirsAPI` that allow iterating over both user and site dirs/paths. by [@​SpaceshipOperations](https://togithub.com/SpaceshipOperations) in [platformdirs/platformdirs#258 #### New Contributors - [@​SpaceshipOperations](https://togithub.com/SpaceshipOperations) made their first contribution in [platformdirs/platformdirs#258 **Full Changelog**: platformdirs/platformdirs@4.1.0...4.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctypes in windows is perfectly optional, but it doesn't fall back to other methods when
import ctypesfails.