Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for drush 9.0.0-rc1 (changed alias file naming convention again) #655

Closed
hanoii opened this issue Dec 3, 2017 · 2 comments
Closed

Comments

@hanoii
Copy link
Contributor

hanoii commented Dec 3, 2017

See

https://github.com/drush-ops/drush/releases/tag/9.0.0-rc1

Simplified site aliases. Fixes #3107 (#3184)

More specifically: drush-ops/drush#3107 (comment)

I updated drush and was driving me nuts why aliases were not there.

Renaming group.alias.yml to group.site.yml

Kind of worked.

There's another issue though, which is that running platform drush-aliases -r now doesn't work because it runs:

drush @none sa @OLDGROUP

If you are creating aliases for the first time and group is not there, before it simply return a string but the command was OK, now it throws an exception so the aliases can't be generated.

The above becomes the norm when you update drush as it simply find no aliases.

See: https://github.com/platformsh/platformsh-cli/blob/71b40df52a5534acb801e634f5c08595d2e1f2d6/src/Service/Drush.php#L230

@pjcdawkins
Copy link
Collaborator

I'm not sure I understand the last part - what exception is thrown? It's supposed to be OK with no aliases being found:
https://github.com/platformsh/platformsh-cli/blob/71b40df52a5534acb801e634f5c08595d2e1f2d6/src/Service/Drush.php#L242-L246

@pjcdawkins
Copy link
Collaborator

pjcdawkins commented Dec 4, 2017

Ah... reproduced. The error message changed from Not found to Site alias not found...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants