Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: no-throws-string #43

Closed
platinumazure opened this issue Jun 27, 2016 · 1 comment
Closed

New rule: no-throws-string #43

platinumazure opened this issue Jun 27, 2016 · 1 comment

Comments

@platinumazure
Copy link
Owner

assert.throws has removed (block, string, string) signature in QUnit 2.0. Need a new rule to catch this and add to qunit/two configuration.

Probably worth adding to qunit/recommended configuration, since (block, regex, string) is more flexible anyway.

No need to flag (block, string) form as that has always been interpreted as an assertion message rather than an expected string, so its behavior is unchanged.

Marked as "breaking" since changes to shared configurations are very likely to be breaking changes.

@platinumazure
Copy link
Owner Author

Removing "breaking" label because I can create a separate issue to merge into the shared configs later (only the shared config changes are breaking).

@platinumazure platinumazure added this to the 1.1.0 milestone Jul 8, 2016
@platinumazure platinumazure changed the title New rule: no-throws-error-string New rule: no-throws-string Jul 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant