Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous expression in example workflow config #21

Closed
caic99 opened this issue Apr 16, 2022 · 1 comment
Closed

Ambiguous expression in example workflow config #21

caic99 opened this issue Apr 16, 2022 · 1 comment

Comments

@caic99
Copy link
Contributor

caic99 commented Apr 16, 2022

# Optionally set the number of comments per review
# to avoid GitHub API timeouts for heavily loaded
# pull requests
suggestions_per_comment: 10

Here, the comment says this is "the number of comments per review", but the variable name gives us "suggestions per comment". I suppose the latter one is actually what you mean.

@platisd
Copy link
Owner

platisd commented Apr 16, 2022

Haha, well I see where to confusion can come from.
I think the most accurate is "suggestions per review" actually. 🤣
Github doesn't like when too many suggestions/comments are left at once (ie per review) so we split the necessary comments/suggestions over multiple code reviews.

@platisd platisd closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants