Ignore unknown countries #2556
Merged
Ignore unknown countries #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
vinibrsl
approved these changes
Jan 3, 2023
aerosol
pushed a commit
that referenced
this pull request
Jan 4, 2023
* Ignore XX and T1 countries * Add fallback if country_code=nil * Lookup city overrides directly in CityOverrides module * Changelog * Add empty moduledoc * Remove redundant comment
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There are some country codes we're recording that cannot be displayed. These are not real countries they are:
XX- disputed territory (https://sentry.plausible.io/organizations/sentry/issues/1095/events/b01fa99ae92f4712ba3579371416be39/?environment=prod&project=1)T1- Tor exit node (https://sentry.plausible.io/organizations/sentry/issues/1095/events/af5adb05fb79486d9e90f48cf3707be6/?environment=prod&project=1)Also makes the following changes:
Tests
Changelog
Documentation
Dark mode