Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .edgesIgnoringSafeArea line from sample app code #21

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Remove .edgesIgnoringSafeArea line from sample app code #21

merged 1 commit into from
Apr 12, 2020

Conversation

kagemiku
Copy link
Contributor

@kagemiku kagemiku commented Apr 6, 2020 •
edited

Checklist

  • All tests are passed.
  • Added tests or Playbook scenario.
  • Documented the code using Xcode markup.
  • Searched existing pull requests for ensure not duplicated.

Description

Remove .edgesIgnoringSafeArea line from sample app code

Related Issue

Closes #20

Motivation and Context

Screenshot

Fixed screen shot:
Screen Shot 2020-04-06 at 21 26 20

@kagemiku kagemiku marked this pull request as ready for review April 7, 2020 02:08
@ra1028
Copy link
Member

ra1028 commented Apr 12, 2020

Thanks @kagemiku !

Great catchup 👍

@ra1028 ra1028 merged commit 61eaf33 into playbook-ui:master Apr 12, 2020
@kagemiku kagemiku deleted the fix-sample-app-safearea-bug branch April 12, 2020 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample App's layout is broken in iOS13.4 simulator
2 participants
@kagemiku @ra1028